From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix SortTocFromFile() to cope with lines that are too long for i |
Date: | 2011-04-07 15:41:16 |
Message-ID: | E1Q7rKe-00066X-SY@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix SortTocFromFile() to cope with lines that are too long for its buffer.
The original coding supposed that a dump TOC file could never contain lines
longer than 1K. The folly of that was exposed by a recent report from
Per-Olov Esgard. We only really need to see the first dozen or two bytes
of each line, since we're just trying to read off the numeric ID at the
start of the line; so there's no need for a particularly huge buffer.
What there is a need for is logic to not process continuation bufferloads.
Back-patch to all supported branches, since it's always been like this.
Branch
------
REL8_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/9a9c7c2eb10b8df67c5652a6678a172b83a262eb
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 29 ++++++++++++++++++++++++-----
1 files changed, 24 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2011-04-07 16:25:35 | pgsql: Allow pg_upgrade with PGCLIENTENCODING set |
Previous Message | Bruce Momjian | 2011-04-07 13:57:37 | pgsql: Preserve pg_largeobject_metadata.relfrozenxid in pg_upgrade. |