From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Clean up a few failures to set collation fields in expression no |
Date: | 2011-03-26 18:26:14 |
Message-ID: | E1Q3YBi-0005yB-7m@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Clean up a few failures to set collation fields in expression nodes.
I'm not sure these have any non-cosmetic implications, but I'm not sure
they don't, either. In particular, ensure the CaseTestExpr generated
by transformAssignmentIndirection to represent the base target column
carries the correct collation, because parse_collate.c won't fix that.
Tweak lsyscache.c API so that we can get the appropriate collation
without an extra syscache lookup.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/b23c9fa9293c54a3829093d207be37a7b42cb630
Modified Files
--------------
src/backend/optimizer/path/pathkeys.c | 3 +-
src/backend/optimizer/plan/createplan.c | 2 +
src/backend/optimizer/util/clauses.c | 2 +-
src/backend/optimizer/util/predtest.c | 4 +++
src/backend/parser/parse_coerce.c | 2 +
src/backend/parser/parse_target.c | 31 ++++++++++++++++++++++---
src/backend/utils/adt/ruleutils.c | 6 +++-
src/backend/utils/cache/lsyscache.c | 38 +++++--------------------------
src/include/utils/lsyscache.h | 5 +--
9 files changed, 49 insertions(+), 44 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-03-26 20:35:38 | pgsql: More collations cleanup, from trawling for missed collation assi |
Previous Message | Simon Riggs | 2011-03-26 10:15:27 | pgsql: Additional test for each commit in sync rep path to plug minute |