pgsql: Move synchronous_standbys_defined updates from WAL writer to BG

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Move synchronous_standbys_defined updates from WAL writer to BG
Date: 2011-03-19 01:47:24
Message-ID: E1Q0lGG-0002mU-Fb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move synchronous_standbys_defined updates from WAL writer to BG writer.

This is advantageous because the BG writer is alive until much later in
the shutdown sequence than WAL writer; we want to make sure that it's
possible to shut off synchronous replication during a smart shutdown,
else it might not be possible to complete the shutdown at all.

Per very reasonable gripes from Fujii Masao and Simon Riggs.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/727589995a3e027046f0da7af6ba665b0b47f89f

Modified Files
--------------
src/backend/postmaster/bgwriter.c | 8 ++++++++
src/backend/postmaster/walwriter.c | 6 ------
src/backend/replication/syncrep.c | 6 +++---
3 files changed, 11 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-03-19 02:12:43 pgsql: Fix possible "tuple concurrently updated" error in ALTER TABLE.
Previous Message Robert Haas 2011-03-19 01:23:47 pgsql: Woops. Previous patch to remove -X options missed getopt_long c