pgsql: Split CollateClause into separate raw and analyzed node types.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Split CollateClause into separate raw and analyzed node types.
Date: 2011-03-11 21:28:34
Message-ID: E1Py9sw-0001vt-Bm@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split CollateClause into separate raw and analyzed node types.

CollateClause is now used only in raw grammar output, and CollateExpr after
parse analysis. This is for clarity and to avoid carrying collation names
in post-analysis parse trees: that's both wasteful and possibly misleading,
since the collation's name could be changed while the parsetree still
exists.

Also, clean up assorted infelicities and omissions in processing of the
node type.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8acdb8bf9cebc42cee5aa96a2d594756b44173c9

Modified Files
--------------
src/backend/catalog/dependency.c | 43 ++++++++++-----
src/backend/commands/typecmds.c | 2 +-
src/backend/executor/execQual.c | 54 ++++++++++----------
src/backend/nodes/copyfuncs.c | 21 +++++++-
src/backend/nodes/equalfuncs.c | 16 +++++-
src/backend/nodes/nodeFuncs.c | 45 +++++++++-------
src/backend/nodes/outfuncs.c | 24 +++++++--
src/backend/nodes/readfuncs.c | 35 ++++++-------
src/backend/optimizer/util/clauses.c | 48 +++++++++++++++++
src/backend/parser/gram.y | 10 ++--
src/backend/parser/parse_coerce.c | 16 ++++--
src/backend/parser/parse_expr.c | 10 ++--
src/backend/parser/parse_target.c | 2 +-
src/backend/parser/parse_type.c | 2 +-
src/backend/parser/parse_utilcmd.c | 2 +-
src/backend/utils/adt/ruleutils.c | 60 ++++++++++++++++-----
src/include/catalog/catversion.h | 2 +-
src/include/nodes/nodes.h | 3 +-
src/include/nodes/parsenodes.h | 11 ++++
src/include/nodes/primnodes.h | 24 ++++----
src/pl/plpgsql/src/pl_exec.c | 3 +
src/test/regress/expected/collate.linux.utf8.out | 4 +-
22 files changed, 298 insertions(+), 139 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-03-11 23:19:28 pgsql: Put in some more safeguards against executing a division-by-zero
Previous Message Kevin Grittner 2011-03-11 20:10:05 Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.