| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix tsmatchsel() to account properly for null rows. |
| Date: | 2011-02-18 00:01:15 |
| Message-ID: | E1PqDmd-0002pV-IT@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix tsmatchsel() to account properly for null rows.
ts_typanalyze.c computes MCE statistics as fractions of the non-null rows,
which seems fairly reasonable, and anyway changing it in released versions
wouldn't be a good idea. But then ts_selfuncs.c has to account for that.
Failure to do so results in overestimates in columns with a significant
fraction of null documents. Back-patch to 8.4 where this stuff was
introduced.
Jesper Krogh
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/2b3a0630b54ff9970a7cd2c78a686015f9a53c0c
Modified Files
--------------
src/backend/tsearch/ts_selfuncs.c | 6 ++++++
src/include/catalog/pg_statistic.h | 2 ++
2 files changed, 8 insertions(+), 0 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-02-18 01:23:03 | pgsql: pgindent run on plperl.c |
| Previous Message | Tom Lane | 2011-02-17 23:11:50 | pgsql: Fix upgrade of contrib/xml2 from 9.0. |