pgsql: In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate th

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate th
Date: 2010-11-09 15:52:40
Message-ID: E1PFqUy-0002hX-GC@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate the tuple
length stored in the line pointer the same way it's calculated in the normal
heap_insert() codepath. As noted by Jeff Davis, the length stored by
raw_heap_insert() included padding but the one stored by the normal codepath
did not. While the mismatch seems to be harmless, inconsistency isn't good,
and the normal codepath has received a lot more testing over the years.

Backpatch to 8.3 where the heap rewrite code was introduced.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=39a67533975c8cbadf3d755216cea3ec2c3ce64c

Modified Files
--------------
src/backend/access/heap/rewriteheap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-11-09 16:57:17 pgsql: Repair memory leakage while ANALYZE-ing complex index expression
Previous Message Alvaro Herrera 2010-11-09 14:33:55 pgsql: plpython has plpy.Error instead of plpy.ERROR