From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Remove some unnecessary tests of pgstat_track_counts. |
Date: | 2010-10-12 18:44:43 |
Message-ID: | E1P5jq7-00083G-6e@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove some unnecessary tests of pgstat_track_counts.
We may as well make pgstat_count_heap_scan() and related macros just count
whenever rel->pgstat_info isn't null. Testing pgstat_track_counts buys
nothing at all in the normal case where that flag is ON; and when it's OFF,
the pgstat_info link will be null, so it's still a useless test.
This change is unlikely to buy any noticeable performance improvement,
but a cycle shaved is a cycle earned; and my investigations earlier today
convinced me that we're down to the point where individual instructions in
the inner execution loops are starting to matter.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f4d242ef94730c447d87b9840a40b0ec3371fe0f
Modified Files
--------------
src/backend/postmaster/pgstat.c | 8 ++++----
src/include/pgstat.h | 14 +++++++-------
2 files changed, 11 insertions(+), 11 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Itagaki Takahiro | 2010-10-13 05:43:07 | pgsql: Accept 'public' as a pseudo-role name in has_table_privilege() a |
Previous Message | Alvaro Herrera | 2010-10-12 16:32:18 | pgsql: Fix typo |