Re: PATCH: CITEXT 2.0 v3

On Jul 14, 2008, at 11:06, Tom Lane wrote:

> [ shrug... ] Seems pretty useless to me: we already know that it
> works
> for you. The point of a regression test in my mind is to make sure
> that
> it works for everybody. Given the platform variations involved in
> strcoll's behavior, the definition of "works for everybody" is going
> to
> be pretty darn narrowly circumscribed anyway, and thus I don't have a
> big problem with restricting the tests to ASCII cases.

Neither do I, as long as there is *some* context to ensure that the
type remains locale-aware. We only know that it works for me because
I've written the tests.

> Let me put it another way: if we test on another platform and find out
> that strcoll's behavior is different there, are you going to fix that
> version of strcoll? No, you're not. So you might as well just test
> the
> behavior of the code that's actually under your control.

You don't seem to understand what I'm suggesting: I'm not talking
about testing strcoll. I'm talking about making sure that citext
*uses* strcoll. Whether or not strcoll actually works properly is not
my concern.

Best,

David