Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

> On 29 Nov 2017, at 04:29, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>
> On Tue, Nov 28, 2017 at 10:07 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> I was just looking at the tsearch code which uses pg_strcmpcase, and
>> those are defined with makeDefElem() so you should switch to strcmp in
>> this case as well, no? If I patch the code myself I would get an error
>> when double-quoting, making those command more consistent with the
>> rest of what you are patching here:
>> create extension unaccent;
>> alter text search dictionary unaccent (Rules = 'unaccent'); -- ok
>> alter text search dictionary unaccent (RuLes = 'unaccent'); -- ok
>> alter text search dictionary unaccent ("Rules" = 'unaccent'); -- error
>
> Daniel, I am waiting for your input on this one, and you did not have
> much time to send an update.

Sorry for the slow updates, I managed to catch a nasty fever which turned my
brain closer to a mushroom soup than I’d like.

> So I am moving this patch to next CF.

Good move, thanks!

cheers ./daniel