Quick Links

[PATCH] Use RelationClose rather than table_close in heap_create_with_catalog

From:	Xiaoran Wang <wxiaoran(at)vmware(dot)com>
To:	"pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject:	[PATCH] Use RelationClose rather than table_close in heap_create_with_catalog
Date:	2023-03-18 07:04:45
Message-ID:	DS0PR05MB968933DCAB6EC48776102A7BBA829@DS0PR05MB9689.namprd05.prod.outlook.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers

Hi hackers,

In heap_create_with_catalog, the Relation new_rel_desc is created
by RelationBuildLocalRelation, not table_open. So it's better to
call RelationClose to release it.

What's more, the comment for it seems useless, just delete it.

Thanks!

Attachment	Content-Type	Size
0001-Use-RelationClose-rather-than-table_close-in-heap_cr.patch	application/octet-stream	1.1 KB

Responses

Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog at 2023-05-10 02:57:46 from tender wang
Re: [PATCH] Use RelationClose rather than table_close in heap_create_with_catalog at 2023-05-10 14:17:24 from Bharath Rupireddy

Browse pgsql-hackers by date

	From	Date	Subject
Next Message	vignesh C	2023-03-18 09:03:27	Re: Allow logical replication to copy tables in binary format
Previous Message	Amit Kapila	2023-03-18 05:35:22	Re: logical decoding and replication of sequences, take 2