RE: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue

Thank you for such a timely response and the best and most fully featured database software money can't buy!

Sent from my Samsung Galaxy smartphone.

-------- Original message --------
From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Date: 4/9/20 10:48 AM (GMT-05:00)
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ethan Waldo <ewaldo(at)healthetechs(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue

On 2020-04-05 17:26, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> Confirmed. Attached is a patch to fix it. Thanks for the report!
>
> LGTM. Perhaps extend the comment block just above, adding something
> like "We must fill the attmap now so it can be used to process
> GENERATED default expressions in the per-column loop."

Committed with that.

Ethan, this will be in the next minor release of PostgreSQL 12.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services