Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Hi,

On February 3, 2022 7:48:40 AM PST, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>Pouring over SSL test logs I was again red-herringed by the warning we get for
>using hex() on a large input value, before I remembered that it's benign and
>emerged from the rabbithole:
>
> Hexadecimal number > 0xffffffff non-portable at t/001_ssltests.pl line 508.
>
>We could suppress it by turning off warnings for that line, since we know it
>will work due to the 64-bit int test a few lines before:
>
>@@ -505,6 +505,7 @@ if ($? == 0)
> {
> $serialno =~ s/^serial=//;
> $serialno =~ s/\s+//g;
>+ local $SIG{'__WARN__'} = sub { };
> $serialno = hex($serialno);
> }
> else
>
>Turning of warnings might be a bridge too far for some though? Thoughts?

Can't we just chop serialno into two 32bit numbers and call hex separately? Seems about as hard as adding a comment explaining what the warn bit is about...

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.