| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Replacing TAP test planning with done_testing() |
| Date: | 2022-02-09 14:01:36 |
| Message-ID: | DD399313-3D56-4666-8079-88949DAC870F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Whether or not to explicitly plan the number of TAP tests per suite has been
discussed a number of times on this list, often as a side-note in an unrelated
thread which adds/modifies a test. The concensus has so far weighed towards
not doing manual bookkeeping of test plans but to let Test::More deal with it.
So far, no concrete patch to make that happen has been presented though.
The attached patch removes all Test::More planning and instead ensures that all
tests conclude with a done_testing() call. While there, I also removed a few
exit(0) calls from individual tests making them more consistent.
Thoughts?
--
Daniel Gustafsson https://vmware.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Replace-Test-More-plans-with-done_testing.patch | application/octet-stream | 92.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-02-09 14:04:34 | Typo in archive modules docs |
| Previous Message | Julien Rouhaud | 2022-02-09 13:52:30 | Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) |