| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Making background psql nicer to use in tap tests |
| Date: | 2023-04-03 08:39:41 |
| Message-ID: | DB4FC039-550B-4079-A650-E6FC22C3A984@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 2 Apr 2023, at 23:37, Andres Freund <andres(at)anarazel(dot)de> wrote:
> There's this XXX that I added:
>
>> @@ -57,11 +51,10 @@ sub test_streaming
>> COMMIT;
>> });
>>
>> - $in .= q{
>> - COMMIT;
>> - \q
>> - };
>> - $h->finish; # errors make the next test fail, so ignore them here
>> + $h->query_safe('COMMIT');
>> + $h->quit;
>> + # XXX: Not sure what this means
>> + # errors make the next test fail, so ignore them here
>>
>> $node_publisher->wait_for_catchup($appname);
>
> I still don't know what that comment is supposed to mean, unfortunately.
My reading of it is that it's ignoring any croak errors which IPC::Run might
throw if ->finish() isn't able to reap the psql process which had the \q.
I've added Amit who committed it in 216a784829c on cc: to see if he remembers
the comment in question and can shed some light. Skimming the linked thread
yields no immediate clues.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-04-03 08:42:02 | Re: SQL JSON path enhanced numeric literals |
| Previous Message | Drouvot, Bertrand | 2023-04-03 07:09:50 | Re: Pass heaprel to GlobalVisTestFor() in vacuumRedirectAndPlaceholder() |