| From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Christoph Berg <myon(at)debian(dot)org>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-16 16:04:40 |
| Message-ID: | DB4707F5-0805-4D8B-8571-89735AA9321A@justatheory.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Nov 15, 2024, at 19:30, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> That text says exactly nothing about what specific code changes to
> make or not make. I'm not sure offhand where (or if) we have this
> documented, but there's an idea that adding fields at the end of
> a struct is safer ABI-wise than putting them in the middle. Which
> is true if you can't squeeze them into padding space. Here, that
> could have been done and probably should have.
>
> The other bit of documentation we probably need is some annotation in
> struct ResultRelInfo saying "do not change the sizeof() this struct
> in back branches, period”.
This sounds like complementary documentation for committers; totally agree the guidance should be written down somewhere.
D
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2024-11-16 16:22:14 | Re: Improving btree performance through specializing by key shape, take 2 |
| Previous Message | Tom Lane | 2024-11-16 15:44:09 | Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4 |