Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

From: "Robin Haberkorn" <haberkorn(at)b1-systems(dot)de>
To: <pgsql-hackers(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details
Date: 2025-04-28 11:12:22
Message-ID: D9I86M48OZ07.19RYHTDE8ANDM@b1-systems.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue Apr 22, 2025 at 17:47:20 GMT +03, Robin Haberkorn wrote:
> Perhaps you can tell me what else is preventing adoption into core. I believe
> that xslt_process() should also accept the `xml` type as an alternative to
> strings. Strings should be kept for backwards compatibility, though. Also,
> the stylesheet parameter passing is very crude and limited. I suggest, that
> the current method of passing them as strings (see parse_params()) is
> deprecated and we don't try to tackle its limitations, but will instead
> accept hstores. If you agree, I will work on these two tasks next.

On the other hand, since hstore is a module, it seems we cannot really
have any other module or core depend on it, correct?
Perhaps the xmltype-variant of xslt_process() could accept string arrays
instead.

--
Robin Haberkorn
Senior Software Engineer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shayon Mukherjee 2025-04-28 11:23:15 Re: [PATCH] Re: Proposal to Enable/Disable Index using ALTER INDEX
Previous Message Nisha Moond 2025-04-28 11:03:02 Re: Fix slot synchronization with two_phase decoding enabled