| From: | Dent John <denty(at)QQdd(dot)eu> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: [PATCH] Do not use StdRdOptions in Access Methods |
| Date: | 2019-10-09 19:26:14 |
| Message-ID: | D66580BA-59EF-41C2-8EBD-18A45306B627@QQdd.eu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Oct 2019, at 11:33, Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
>
> Whoa-whoa!
>
> I am not inventing something new here. Same code is already used in brin
> (brin.c:820), gin (ginutils.c:602) and gist (gistutils.c:909) indexes. I've
> just copied the idea, to do all index code uniform.
>
> This does not mean that these code can't be improved, but as far as I can
> guess it is better to do it in small steps, first make option code uniform, and
> then improve all of it this way or another...
I didn’t spot it was an existing pattern.
And I agree — making the code uniform will make it easier to evolve in future.
Gets my vote.
denty.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-10-09 19:37:59 | Re: Collation versioning |
| Previous Message | Peter Eisentraut | 2019-10-09 19:19:20 | Re: Collation versioning |