| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Restart pg_usleep when interrupted |
| Date: | 2024-08-07 21:22:22 |
| Message-ID: | D1558DDA-CEED-4CED-B3ED-C425D996FCA3@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> On Wed, Aug 07, 2024 at 06:00:53AM +0000, Bertrand Drouvot wrote:
>> + SleepEx((microsec < 500 ? 1 : (microsec + 500) / 1000), FALSE);
>
> I think this deserves a comment.
>
Done
>> +#define INSTR_TIME_ADD_MICROSEC(x,t) \
>> + ((x).ticks += t * NS_PER_US)
>
> I'd add parentheses around "t" to ensure any expressions given as "t" are
> evaluated first.
>
Done
> Also, do we need to worry about overflow here? It looks like the rest of
> instr_time.h is oblivious about overflow, so maybe this is better discussed
> in a separate thread...
>
I agree, this needs to be handled in a different thread.
Please see v7.
Regards,
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-vaccum_delay-with-absolute-time-nanosleep.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-08-07 21:39:57 | Re: New GUC autovacuum_max_threshold ? |
| Previous Message | Paul Jungwirth | 2024-08-07 20:54:52 | Re: SQL:2011 application time |