Re: Fix to not check included columns in ANALYZE on indexes

On June 28, 2018 4:18:36 PM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> writes:
>> I found that both key columns and included columns are checked when
>analyze
>> is run on indexes. This is almost harmless because non-expression
>columns
>> are not processed. However, this check is obviously unnecessary and
>we
>> can fix this to not check included columns. If we decide to support
>expressions
>> in included columns in future, this must be fixed eventually.
>
>AFAICS, we'd just have to revert this patch later, so I don't see
>much value in it.
>
>Also, is it really true that we don't support included expression
>columns now? In what way would that not be a bug?

I don't think IOS supports expression columns, right? Away from code for a bit, so can't check. If indeed true, there'd be little point in allowing it, right?

Andres

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.