From: | "MauMau" <maumau307(at)gmail(dot)com> |
---|---|
To: | "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>, "Erik Rijkers" <er(at)xs4all(dot)nl>, "Petr Jelinek" <petr(at)2ndquadrant(dot)com> |
Subject: | Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop] |
Date: | 2014-06-26 13:26:01 |
Message-ID: | D053F9D6F058425788F12CD7BB5249C9@maumau |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
From: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
> fixed
Thank you. All is fine.
>> should be ""Environment variables". And this section lacks description
>> for Windows, such as:
>>
>> + printf(_(" NAME=VALUE [NAME=VALUE] psql ...\n or \\setenv NAME
>> [VALUE]
>> in interactive mode\n\n"));
>>
>> + printf(_(" PGPASSFILE password file (default ~/.pgpass)\n"));
>>
>
> ??? -
I meant that how to set environment variables on Windows command prompt is
different from on UNIX/Linux, and the default password file path is also
different on Windows. Do we describe them in this help?
Lastly, to follow most of your descriptions, "s" at the end of the first
verb in these messages should be removed. For example, use "set" instead of
"sets".
+ printf(_(" COMP_KEYWORD_CASE determines which letter case to use when
completing an SQL key word\n"));
+ printf(_(" columns sets the target width for the wrapped
format\n"));
+ printf(_(" linestyle sets the border line drawing style [ascii,
old-ascii, unicode]\n"));
+ printf(_(" recordsep specifies the record (line) separator to
use in unaligned output format\n"));
+ printf(_(" title sets the table title for any subsequently
printed tables\n"));
This is all I noticed in the review.
Regards
MauMau
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2014-06-26 13:35:44 | Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop] |
Previous Message | Heikki Linnakangas | 2014-06-26 13:21:45 | Re: crash with assertions and WAL_DEBUG |