Re: Add BF member koel-like indentation checks to SanityCheck CI

On Wed Jan 10, 2024 at 1:58 AM CST, Tom Lane wrote:
> Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> > IMO, running the
> > pgindent in at least one of the CI systems if not all (either as part
> > task SyanityCheck or task Linux - Debian Bullseye - Autoconf) help
> > catches things early on in CF bot runs itself. This saves committers
> > time but at the cost of free run-time that cirrus-ci provides.
>
> But that puts the burden of pgindent-cleanliness onto initial patch
> submitters, which I think is the wrong thing for reasons mentioned
> upthread. We want to enforce this at commit into the master repo, but
> I fear enforcing it earlier will drive novice contributors away for
> no very good reason.

If we are worried about turning away novice contributors, there are much
bigger fish to fry than worrying if we will turn them away due to
requiring code to be formatted a certain way. Like I said earlier,
formatters are pretty common tools to be using these days. go fmt, deno
fmt, rustfmt, prettier, black, clang-format, uncrustify, etc.

Code formatting requirements are more likely to turn someone away from
contributing if code reviews are spent making numerous comments.
Luckily, we can just say "run this command line incantation of
pgindent," which in the grand scheme of things is easy compared to all
the other things you have to be aware of to contribute to Postgres.

--
Tristan Partin
Neon (https://neon.tech)