Reading backup label file for checkpoint and redo location during crash recovery

From: Satyanarayana Narlapuram <Satyanarayana(dot)Narlapuram(at)microsoft(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Reading backup label file for checkpoint and redo location during crash recovery
Date: 2017-09-25 16:23:39
Message-ID: CY1PR21MB002499FF81D3BD2D74B83546917A0@CY1PR21MB0024.namprd21.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi there,

During crash recovery, last checkpoint record information is obtained from the backup label if present, instead of getting it from the control file. This behavior is causing PostgreSQL database cluster not to come up until the backup label file is deleted (as the error message says).

if (checkPoint.redo < checkPointLoc)
{
if (!ReadRecord(xlogreader, checkPoint.redo, LOG, false))
ereport(FATAL,
(errmsg("could not find redo location referenced by checkpoint record"),
errhint("If you are not restoring from a backup, try removing the file \"%s/backup_label\".", DataDir)));
}

If we are recovering from a dump file, reading from the backup label files makes sense as the control file could be archived after a few checkpoints. But this is not the case for crash recovery, and is always safe to read the checkpoint record information from the control file.
Is this behavior kept this way as there is no clear way to distinguish between the recovery from the dump and the regular crash recovery?

Thanks,
Satya

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-09-25 16:30:16 Re: logical replication and statistics
Previous Message Robert Haas 2017-09-25 16:13:27 Re: Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().