| From: | "Tristan Partin" <tristan(at)neon(dot)tech> |
|---|---|
| To: | "Tristan Partin" <tristan(at)neon(dot)tech>, "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>, "Daniel Gustafsson" <daniel(at)yesql(dot)se> |
| Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Euler Taveira" <euler(at)eulerto(dot)com>, "Michael Banck" <mbanck(at)gmx(dot)net>, "PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add --check option to pgindent |
| Date: | 2023-12-18 21:18:47 |
| Message-ID: | CXRRU5Z7R9XN.3JZTO6G7PTKSU@neon.tech |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon Dec 18, 2023 at 10:50 AM CST, Tristan Partin wrote:
> On Mon Dec 18, 2023 at 10:14 AM CST, Jelte Fennema-Nio wrote:
> > On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > > I think this is pretty much ready to go, the attached v4 squashes the changes
> > > and fixes the man-page which also needed an update. The referenced Wiki page
> > > will need an edit or two after this goes in, but that's easy enough.
> >
> > One thing I'm wondering: When both --check and --diff are passed,
> > should pgindent still early exit with 2 on the first incorrectly
> > formatted file? Or should it show diffs for all failing files? I'm
> > leaning towards the latter making more sense.
>
> Makes sense. Let me iterate on the squashed version of the patch.
Here is an additional patch which implements the behavior you described.
The first patch is just Daniel's squashed version of my patches.
--
Tristan Partin
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Rename-non-destructive-modes-in-pgindent.patch | text/x-patch | 4.4 KB |
| v5-0002-Print-all-diffs-with-pgindent-check.patch | text/x-patch | 924 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-12-18 21:34:05 | Re: Add --check option to pgindent |
| Previous Message | Robert Haas | 2023-12-18 21:00:30 | Re: index prefetching |