Re: Clean up find_typedefs and add support for Mac

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Subject: Re: Clean up find_typedefs and add support for Mac
Date: 2023-12-13 17:23:50
Message-ID: CXNDPJZ3TMF7.E06EJFULOOZI@neon.tech
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue Dec 12, 2023 at 5:02 PM CST, Tom Lane wrote:
> "Tristan Partin" <tristan(at)neon(dot)tech> writes:
> > The big patch here is adding support for Mac. objdump -W doesn't work on
> > Mac. So, I used dsymutil and dwarfdump to achieve the same result.
>
> We should probably nuke the current version of src/tools/find_typedef
> altogether in favor of copying the current buildfarm code for that.
> We know that the buildfarm's version works, whereas I'm not real sure
> that src/tools/find_typedef is being used in anger by anyone. Also,
> we're long past the point where developers can avoid having Perl
> installed.
>
> Ideally, the buildfarm client would then start to use find_typedef
> from the tree rather than have its own copy, both to reduce
> duplication and to ensure that the in-tree copy keeps working.

That makes sense to me. Where can I find the buildfarm code to propose
a different patch, at least pulling in the current state of the
buildfarm script? Or perhaps Andrew is the best person for this job.

--
Tristan Partin
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-12-13 17:24:25 Re: Eager page freeze criteria clarification
Previous Message Jeff Davis 2023-12-13 17:12:25 Re: Built-in CTYPE provider