| From: | "Tristan Partin" <tristan(at)neon(dot)tech> |
|---|---|
| To: | "Andres Freund" <andres(at)anarazel(dot)de>, "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
| Cc: | <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* |
| Date: | 2023-12-01 21:55:29 |
| Message-ID: | CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Commits look fine to me, but I hate the new target names... Luckily,
I just use plain ninja, so I don't interact with that.
> + for name, v in targets_info_byname.items():
> + if len(targets_info_byname[name]) > 1:
My only comment is that you could reverse the logic and save yourself an
indentation.
- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+ continue
But whatever you want.
--
Tristan Partin
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-12-01 22:12:55 | Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* |
| Previous Message | Heikki Linnakangas | 2023-12-01 20:40:55 | pgsql: Silence Valgrind complaint with EXEC_BACKEND |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2023-12-01 22:01:05 | Re: [RFC] Clang plugin for catching suspicious typedef casting |
| Previous Message | Nathan Bossart | 2023-12-01 21:50:39 | Re: [PATCH] pg_convert improvement |