RE: Psql meta-command conninfo+

From:	Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>
To:	"Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:	Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, Erik Wienhold <ewie(at)ewie(dot)name>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject:	RE: Psql meta-command conninfo+
Date:	2024-05-29 12:37:21
Message-ID:	CP8P284MB24968D07114AEF73D3160896ECF22@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM
Views:	Raw Message | Whole Thread | Download mbox | Resend email
Thread:	2024-02-06 17:27:01 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎  2024-02-06 18:19:19 from Nathan Bossart <nathandbossart(at)gmail(dot)com>   2024-02-06 19:10:54 from Erik Wienhold <ewie(at)ewie(dot)name>    2024-02-06 20:52:09 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎     2024-02-06 21:06:05 from Nathan Bossart <nathandbossart(at)gmail(dot)com>      2024-02-06 21:12:05 from Nathan Bossart <nathandbossart(at)gmail(dot)com>       2024-02-06 21:45:54 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>        2024-02-06 21:50:22 from Nathan Bossart <nathandbossart(at)gmail(dot)com>         2024-02-07 04:13:40 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎          2024-02-07 09:54:21 from Erik Wienhold <ewie(at)ewie(dot)name>           2024-02-07 12:41:56 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎          2024-02-07 12:35:34 from Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>           2024-02-07 14:47:31 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎            2024-02-07 16:40:28 from Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>             2024-02-07 20:13:15 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎              2024-02-08 11:01:55 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>              2024-02-08 11:01:55 from Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>               2024-02-08 14:58:19 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                2024-02-09 07:58:15 from Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>                 2024-02-09 09:18:44 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                 2024-02-12 14:16:00 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                  2024-02-12 21:53:50 from Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>                  2024-02-14 11:36:49 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>                   2024-02-15 19:47:05 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                    2024-02-15 22:16:33 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                     2024-02-16 11:18:45 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>                      2024-02-16 15:54:49 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                       2024-02-17 14:53:43 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                        2024-02-21 23:30:17 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                        2024-02-24 20:44:12 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                         2024-02-29 22:02:21 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                          2024-02-29 22:41:31 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                           2024-03-18 22:05:17 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                            2024-03-27 13:23:32 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                             2024-03-27 23:08:24 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                              2024-03-28 19:07:47 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                               2024-03-29 06:13:56 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                2024-03-30 16:23:24 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                 2024-03-30 17:09:19 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>                                  2024-03-31 21:39:54 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                   2024-04-01 10:51:18 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>                                    2024-04-01 14:53:05 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                     2024-04-01 16:22:41 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>                                      2024-04-01 17:45:10 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                      2024-04-01 19:51:57 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                       2024-04-01 21:29:28 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                        2024-04-03 10:01:08 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                         2024-04-03 17:38:22 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                          2024-04-04 14:34:20 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                          2024-04-04 14:57:46 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                           2024-04-04 15:19:53 from Peter Eisentraut <peter(at)eisentraut(dot)org>                                            2024-04-04 15:42:29 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                                             2024-04-04 15:58:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>                                              2024-04-04 16:15:39 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                                               2024-04-04 16:59:55 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                                               2024-04-05 14:50:18 from Peter Eisentraut <peter(at)eisentraut(dot)org>                                                2024-04-05 16:04:53 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                                 2024-05-29 12:37:21 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                                                  2024-06-03 18:30:21 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                                                   2024-06-05 12:32:20 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                                            2024-04-04 15:53:37 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>                                             2024-04-04 19:20:41 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                 2024-03-31 22:59:44 from "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>                                  2024-04-01 19:19:58 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                          2024-03-14 16:46:11 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                      2024-02-16 21:48:16 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎               2024-02-08 15:50:20 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                2024-02-08 19:37:38 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>                 2024-02-08 20:37:54 from Erik Wienhold <ewie(at)ewie(dot)name>                  2024-02-08 22:28:29 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                   2024-02-09 10:19:03 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>                    2024-02-09 15:33:23 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                    2024-02-10 17:38:23 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                  2024-02-08 23:34:54 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>                   2024-02-09 02:00:11 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                    2024-02-09 02:41:55 from Nathan Bossart <nathandbossart(at)gmail(dot)com>                     2024-02-09 07:24:41 from Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>                      2024-02-09 09:38:35 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>                     2024-02-09 08:30:54 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎                 2024-02-08 20:47:44 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎      2024-02-06 21:39:20 from Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br> 📎
Lists:	pgsql-hackers

In response to

• Re: Psql meta-command conninfo+ at 2024-04-05 16:04:53 from Imseih (AWS), Sami

Responses

• Re: Psql meta-command conninfo+ at 2024-06-03 18:30:21 from Nathan Bossart

Browse pgsql-hackers by date

	From	Date	Subject
Next Message	Alexander Korotkov	2024-05-29 12:53:39	Re: About 0001:,Having overviewed it, I don't see any issues (but I'm the author), except grammatical ones - but I'm not a native to judge it.,Also, the sentence 'turning GROUP BY clauses into pathkeys' is unclear to me. It may be better to write something like: 'building pathkeys by the list of grouping clauses'.,,0002:,The part under USE_ASSERT_CHECKING looks good to me. But the code in group_keys_reorder_by_pathkeys looks suspicious: of course, we do some doubtful work without any possible way to reproduce, but if we envision some duplicated elements in the group_clauses, we should avoid usage of the list_concat_unique_ptr. What's more, why do you not exit from foreach_ptr immediately after SortGroupClause has been found? I think the new_group_clauses should be consistent with the new_group_pathkeys.,,0003:,Looks good,,0004:,I was also thinking about reintroducing the preprocess_groupclause because with the re-arrangement of GROUP-BY clauses according to incoming pathkeys, it d...
Previous Message	Alexander Lakhin	2024-05-29 11:00:00	001_rep_changes.pl fails due to publisher stuck on shutdown