RE: Rename Function: pg_postmaster_start_time

From: Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Rename Function: pg_postmaster_start_time
Date: 2024-11-06 20:17:29
Message-ID: CP4P284MB19687C79A096568E08117D13EC532@CP4P284MB1968.BRAP284.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>I can agree that pg_postmaster_ has the potential to be confusing to users, but
>I agree that if we are to do anything it should be alias while maintaining the
>old name for compatibility.
>
>Looking at similar functions it's clear they don't use the pg_postgres_ prefix,
>like for example pg_conf_load_time. Should this if so be pg_start_time?

The name pg_conf_load_time doesn't seem that confusing to me. However,
it doesn't provide clarity on which specific configuration file or which configuration
was "reloaded," so depending on the user sitting behind the computer, it could
indeed, be considered confusing as well. I wouldn't know how to suggest a better
alias for this function, "pg_conf_load_time." I like to always remind that PostgreSQL
is written for users, not for us. The current names and terms are very clear to us, actually,
extremely clear. For someone here in the hacker community, saying "postgres" or
"postmaster" is irrelevant — we are all more than advanced users of PostgreSQL, but we
are the minority of minorities within the range of users worldwide who use PostgreSQL.
Well, in that sense, I honestly only thought of a better and less confusing name for
"pg_postmaster_start_time." For the other functions that may have poor names,
I haven't done an assessment. I don't have a suggestion for your point, maybe someone
else does. The idea of using aliases would be a long-term solution, if you agree with
me, of course, that we don't write PostgreSQL for ourselves, and good names should
always be considered with the end users in mind.

Maiquel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vladlen Popolitov 2024-11-06 20:34:59 Re: Add column name to error description
Previous Message Mark Hill 2024-11-06 19:59:17 FW: Building Postgres 17.0 with meson