RE: [PATCH] Windows port add support to BCryptGenRandom

De: Michael Paquier
Enviadas: Terça-feira, 17 de Dezembro de 2019 04:34
>So, this basically matches with what the MS documents tell us, and my
>impression: this API is available down to at least MSVC 2008, which is
>much more than what we support on HEAD where one can use MSVC 2013 and
>newer versions. Note that for the minimal platforms supported our
>documentation cite Windows Server 2008 R2 SP1 and Windows 7, implying
>_WIN32_WINNT >= 0x0600.
As concern [1], at src/include/port/win32.h, the comments still references Windows XP and claims about possible MingW break.

>In short, this means two things:
>- Your patch, as presented, is wrong.
Well, I try correct him to target MSVC 2013.

>There is no need to make conditional the use of BCryptGenRandom.
If legacy Windows Crypto API still remain, and the patch can broken MingW, I believe as necessary conditional use of BCryptGenRandom.

Best regards,
Ranier Vilela