| From: | Ranier Vilela <ranier_gyn(at)hotmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH] Memory leak, at src/common/exec.c |
| Date: | 2019-12-17 03:30:01 |
| Message-ID: | CO2PR05MB26290A3995D0EFD808A17989E3500@CO2PR05MB2629.namprd05.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
According to [1], windows does not support setenv, so for the patch to work [3], would need to add it.
With the possibility of setenv going further [2], I am submitting in this thread, the patch to add setenv support on the windows side, avoiding starting a new trhead.
It is based on pre-existing functions, and seeks to correctly emulate the functioning of the POSIX setenv, but has not yet been tested.
If this work is not acceptable then it is finished. And two memory leaks and a possible access beyond heap bounds, reported and not fixed.
regards,
Ranier Vilela
[1] https://www.postgresql.org/message-id/29478.1576537771%40sss.pgh.pa.us
[2] https://www.postgresql.org/message-id/30119.1576538578%40sss.pgh.pa.us
[3] https://www.postgresql.org/message-id/SN2PR05MB264066382E2CC75E734492C8E3510%40SN2PR05MB2640.namprd05.prod.outlook.com
| Attachment | Content-Type | Size |
|---|---|---|
| exec_v2.patch | text/x-patch | 2.1 KB |
| Mkvcbuild_v1.patch | text/x-patch | 1.2 KB |
| win32_setenv_v1.patch | text/x-patch | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2019-12-17 03:37:02 | RE: [Proposal] Level4 Warnings show many shadow vars |
| Previous Message | Dilip Kumar | 2019-12-17 03:03:13 | Re: Fastpath while arranging the changes in LSN order in logical decoding |