| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Luis Carril <luis(dot)carril(at)swarm64(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: Add FOREIGN to ALTER TABLE in pg_dump |
| Date: | 2020-03-19 13:29:42 |
| Message-ID: | CEE097D9-4D1B-4896-BBD4-BECC784D5835@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 15 Jan 2020, at 00:04, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2020-Jan-14, Tom Lane wrote:
>
>> I can't get terribly excited about persuading that test to cover this
>> trivial little bit of logic, but if you are, I won't stand in the way.
>
> Hmm, that's a good point actually: the patch changed several places to
> inject the FOREIGN keyword, so in order to cover them all it would need
> several additional regexps, not just one. I'm not sure that
> 002_pg_dump.pl is prepared to do that without unsightly contortions.
I agree that it doesn't seem worth holding up this patch for that, even though
it would be nice if we do add a test at some point.
> Anyway, other than that minor omission the patch seemed good to me, so I
> don't oppose Tomas pushing the version I posted yesterday. Or I can, if
> he prefers that.
This patch still applies with some offsets and a bit of fuzz, and looking over
the patch I agree with Alvaro.
Moving this patch to Ready for Committer.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mike Palmiotto | 2020-03-19 13:29:53 | Re: Auxiliary Processes and MyAuxProc |
| Previous Message | Pavel Suderevsky | 2020-03-19 13:22:16 | Re: Don't try fetching future segment of a TLI. |