From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Avoid overflow with simplehash |
Date: | 2023-07-06 15:00:09 |
Message-ID: | CE03E888-D183-46E5-96A3-193CCFE9D658@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 6 Jul 2023, at 16:42, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> Em qui., 6 de jul. de 2023 às 11:37, Daniel Gustafsson <daniel(at)yesql(dot)se <mailto:daniel(at)yesql(dot)se>> escreveu:
> #define SH_MAX_SIZE (((uint64) PG_UINT32_MAX) + 1)
> This is Assert, that is, in production this test is not done.
Correct, which implies that it's a test for something which is deemed highly
unlikely to happen in production.
> If the empty element is not found, startelem has PG_UINT64_MAX value,
> which do not fit in uint32.
Can you show an example where the hash isn't grown automatically to accomodate
this such that the assertion is tripped?
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Karina Litskevich | 2023-07-06 15:01:06 | Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c) |
Previous Message | Hannu Krosing | 2023-07-06 14:54:12 | Re: Example Table AM implementation |