| From: | Susan Douglas <susan(dot)douglas(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for pgAdmin4 docs |
| Date: | 2016-05-24 19:03:22 |
| Message-ID: | CC2B4460-D74A-4993-B3B8-054ED9017CBA@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
> On May 24, 2016, at 2:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
>
>> On 24 May 2016, at 18:29, Susan Douglas <susan(dot)douglas(at)enterprisedb(dot)com> wrote:
>>
>>
>>> On May 24, 2016, at 12:02 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Hi
>>>
>>> This seems to be missing the images. Did you remember to git add them,
>>> before diff'ing?
>>
>> I think the .png's are already checked in as part of the last patch...
>
> I don't think so (unless they've been renamed). I had errors about them from Sphinx.
I've created another patch (below) that adds the .rst and .png files, and includes an updated index.rst file that adds the Foreign Table dialog. There are still errors related to the index, but I'd prefer to try to fix them in another patch.
Thanks!
-- Susan
| Attachment | Content-Type | Size |
|---|---|---|
| foreign_table_doc.patch | application/octet-stream | 468.8 KB |
| unknown_filename | text/plain | 562 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2016-05-24 19:16:11 | pgAdmin 4 commit: Fixes #1213 - Dropping the materialized view using a |
| Previous Message | Surinder Kumar | 2016-05-24 18:59:12 | [pgAdmin4][Patch]: Materialized view issues when run on PPAS server |