Re: Suspicious redundant assignment in COPY FROM

From: Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Suspicious redundant assignment in COPY FROM
Date: 2023-09-08 05:54:51
Message-ID: CAPsk3_CbXSQ5wZunkCQLrrvbX7XeTUB8iSG7tYuXxLv4B7yXNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> 于2023年9月8日周五 13:42写道:

Thanks, Michael~

> The assignment of num_phys_attrs could be kept at the same place as
> on HEAD, a bit closer to the palloc0() where it is used.
>

Agreed with this principle. Patch is modified and attached.

--
Jingtang

Attachment Content-Type Size
v2-0001-Remove-redundant-assignment-in-copyfrom.patch application/octet-stream 907 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-09-08 06:06:44 Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Previous Message Andres Freund 2023-09-08 05:45:59 Re: Eager page freeze criteria clarification