Re: Removing unneeded self joins

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Вардан Погосян <vardan(dot)pogosyn(at)yandex(dot)ru>
Cc: Andrei Lepikhov <lepihov(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removing unneeded self joins
Date: 2024-07-16 14:30:47
Message-ID: CAPpHfdvs5FAmAdEryRU4MFx8EjJBNu-zBRoQpzuucM2qKYMv7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Vardan!

Great, thank you!

On Tue, Jul 16, 2024 at 5:26 PM Вардан Погосян <vardan(dot)pogosyn(at)yandex(dot)ru> wrote:
> I did the SJE testing at Andrey's request.
> To do this, I used the automatic testing tool EET (Equivalent Expression Transformation) [1] with some modifications.
> EET transforms the logical conditions in a query, creating multiple queries waiting for the same number of rows.

What revision of patch did you use?

> In order to make sure that the SJE logic is executed at all, I tried to cover the code with ereports() as much as possible.

Could you share this? Probably some of these ereports() we would like to keep.

> During the testing process, I did not find any inconsistencies in the number of rows returned, as well as other critical problems.

Did you use assert-enabled build? I guess you mean no server crashes,
right? Also, could you share some statistics on how long did you run,
what number of queries did you execute etc.?

------
Regards,
Alexander Korotkov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-07-16 15:00:08 Re: Things I don't like about \du's "Attributes" column
Previous Message Andrew Dunstan 2024-07-16 14:27:17 Re: Using LibPq in TAP tests via FFI