Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi

On Thu, Apr 5, 2018 at 1:32 AM, Alexander Korotkov <
a(dot)korotkov(at)postgrespro(dot)ru> wrote:

> On Wed, Apr 4, 2018 at 7:29 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>
>> Skip full index scan during cleanup of B-tree indexes when possible
>>
>
> Thank you for committing this.
>
> It appears that patch contains some redundant variabled. See warnings
> produced
> by gcc-7.
>
> nbtpage.c: In function '_bt_update_meta_cleanup_info':
> nbtpage.c:121:15: warning: variable 'metaopaque' set but not used
> [-Wunused-but-set-variable]
> BTPageOpaque metaopaque;
> ^~~~~~~~~~
> nbtree.c: In function '_bt_vacuum_needs_cleanup':
> nbtree.c:790:15: warning: variable 'metaopaque' set but not used
> [-Wunused-but-set-variable]
> BTPageOpaque metaopaque;
> ^~~~~~~~~~
>
> Attached patch fixes this.
>

Teodor already committed [1] better patch [2] from Kyotaro Horiguchi. This
question is closed.

1.
https://www.postgresql.org/message-id/E1f41xX-00029Y-EO%40gemulon.postgresql.org
2. https://www.postgresql.org/message-id/20180405.181730.
125855581.horiguchi.kyotaro%40lab.ntt.co.jp

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company