From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Introduce hash_search_with_hash_value() function |
Date: | 2024-08-08 08:51:17 |
Message-ID: | CAPpHfdvqgB6YEgExEND88notzb_bf9kq8bfzozo+fUohhWCouQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Aug 8, 2024 at 7:45 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> st 7. 8. 2024 v 22:25 odesílatel Alexander Korotkov <aekorotkov(at)gmail(dot)com> napsal:
>>
>> On Wed, Aug 7, 2024 at 1:34 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> > st 7. 8. 2024 v 12:22 odesílatel Alexander Korotkov <aekorotkov(at)gmail(dot)com> napsal:
>> >> Thank you.
>> >> Please see 40064a8ee1 takes special efforts to match HTAB hash
>> >> function to syscache hash function. By default, their hash values
>> >> don't match and you can't simply use syscache hash value to search
>> >> HTAB. This probably should be mentioned in the header comment of
>> >> hash_seq_init_with_hash_value().
>> >
>> >
>> > yes, enhancing doc should be great + maybe assert
>>
>> Please check the patch, which adds a caveat to the function header
>> comment. I don't particularly like an assert here, because there
>> could be use-cases besides syscache callbacks, which could legally use
>> default hash function.
>
>
> looks well
Thank you, pushed.
------
Regards,
Alexander Korotkov
Supabase
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2024-08-08 19:18:52 | pgsql: Refactor error messages to reduce duplication |
Previous Message | Alexander Korotkov | 2024-08-08 08:50:12 | pgsql: Add a caveat to hash_seq_init_with_hash_value() header comment |
From | Date | Subject | |
---|---|---|---|
Next Message | shveta malik | 2024-08-08 08:54:46 | Re: Found issues related with logical replication and 2PC |
Previous Message | Ertan Küçükoglu | 2024-08-08 08:08:55 | Re: Windows default locale vs initdb |