| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GiST kNN search queue (Re: KNN-GiST with recheck) |
| Date: | 2015-02-17 12:56:10 |
| Message-ID: | CAPpHfdvpsHUN=G3cxUPyVAxN2=nhY+x_49BHNnkdr9Q6a4Dt5g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Mon, Dec 22, 2014 at 1:07 PM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com
> wrote:
> Ok, thanks for the review! I have committed this, with some cleanup and
> more comments added.
>
ISTM that checks in pairingheap_GISTSearchItem_cmp is incorrect. This
function should perform inverse comparison. Thus, if item a should be
checked first function should return 1. Current behavior doesn't lead to
incorrect query answers, but it could be slower than correct version.
------
With best regards,
Alexander Korotkov.
| Attachment | Content-Type | Size |
|---|---|---|
| pairing_heap_cmp_fix.patch | application/octet-stream | 806 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tim Kane | 2015-02-17 13:08:19 | postgres_fdw foreign keys with default sequence |
| Previous Message | Kyotaro HORIGUCHI | 2015-02-17 11:19:11 | Re: How about to have relnamespace and relrole? |