Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()
Date: 2024-01-19 16:18:50
Message-ID: CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jan 19, 2024 at 6:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Alexander Korotkov <akorotkov(at)postgresql(dot)org> writes:
> > Reorder actions in ProcArrayApplyRecoveryInfo()
>
> I'm seeing this warning since this commit:
>
> procarray.c: In function 'ProcArrayApplyRecoveryInfo':
> procarray.c:1172:17: warning: declaration of 'xid' shadows a previous local [-Wshadow=compatible-local]
> TransactionId xid = running->xids[i];
> ^~~
> procarray.c:1056:16: note: shadowed declaration is here
> TransactionId xid;
> ^~~

Thank you for reporting. Must be fixed in 448a3331d9.

------
Regards,
Alexander Korotkov

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-01-19 17:19:21 pgsql: doc: Reorganize section for shared memory and LWLocks.
Previous Message Alexander Korotkov 2024-01-19 16:17:25 pgsql: Fix name collision in c64086b79dba