From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Erik Wienhold <ewie(at)ewie(dot)name> |
Cc: | Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql: fix variable existence tab completion |
Date: | 2024-03-14 14:57:01 |
Message-ID: | CAPpHfdvQUJXYN7rx04XvaFXMwZcvYABK0o2n59=obJO=V8Mi5Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold <ewie(at)ewie(dot)name> wrote:
> On 2024-03-03 03:00 +0100, Steve Chavez wrote:
> > psql has the :{?name} syntax for testing a psql variable existence.
> >
> > But currently doing \echo :{?VERB<Tab> doesn't trigger tab completion.
> >
> > This patch fixes it. I've also included a TAP test.
>
> Thanks. The code looks good, all tests pass, and the tab completion
> works as expected when testing manually.
A nice improvement. I've checked why we have at all the '{' at
WORD_BREAKS and if we're going to break anything by removing that. It
seems that '{' here from the very beginning and it comes from the
default value of rl_basic_word_break_characters [1]. It seems that
:{?name} is the only usage of '{' sign in psql. So, removing it from
WORD_BREAKS shouldn't break anything.
I'm going to push this patch if no objections.
------
Regards,
Alexander Korotkov
From | Date | Subject | |
---|---|---|---|
Next Message | Amul Sul | 2024-03-14 15:05:03 | Re: Add system identifier to backup manifest |
Previous Message | vignesh C | 2024-03-14 14:46:31 | Re: Have pg_basebackup write "dbname" in "primary_conninfo"? |