Re: GIN predicate locking slows down valgrind isolationtests tremendously

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Shubham Barai <shubhambaraiss(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: GIN predicate locking slows down valgrind isolationtests tremendously
Date: 2018-12-25 20:54:23
Message-ID: CAPpHfdvOOtRxrLiaROky2wBVWAtQtth9TQ8RpZ361+MFOBm8YA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 25, 2018 at 4:32 AM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> On Tue, Dec 25, 2018 at 12:19 AM Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> > So, we're checking for conflict on tree root for every entry insert.
> > That's right for posting tree, but completely unneeded for entry tree.
> > I'm intended to change that to lock root of only posting tree if
> > nobody explains me why I'm wrong...
>
> BTW, I've tried to remove conflict checking from entry tree root
> (patch is attached). Neither current or my version of isolation tests
> appear to be affected.

Given no comments yet, I'll commit this on no objection.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-12-25 23:28:54 Re: Shared Memory: How to use SYSV rather than MMAP ?
Previous Message Tomas Vondra 2018-12-25 20:50:35 Re: Performance issue in foreign-key-aware join estimation