From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
---|---|
To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Dimension limit in contrib/cube (dump/restore hazard?) |
Date: | 2018-08-30 11:28:20 |
Message-ID: | CAPpHfdvJgWjxHsJTtT+o1tz3OR8EFHcLQjhp-d3+UcmJLh-fQA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
On Tue, Aug 28, 2018 at 10:30 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> > 28 авг. 2018 г., в 14:18, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> написал(а):
> >
> > OK, but I think cube_c_f8() and cube_c_f8_f8() also need to be
> > revised. Also, I think this behavior should be covered by regression
> > tests.
> True. Also there's one case in cube_subset.
In general looks good for me. Personally I get tired with cube.out
and cube_2.out. They are different with only few checks involving
scientific notation. But all the patches touching cube regression
tests should update both cube.out and cube_2.out. I propose to split
scientific notation checks into separate test. I've also add check
for sube_subset().
I'm going to check this patchset on Windows and commit if no objections.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment | Content-Type | Size |
---|---|---|
0001-cube-split-scientific-notation-test-v1.patch | application/octet-stream | 55.1 KB |
0002-cube-enforce-dimension-checks-v1.patch | application/octet-stream | 10.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2018-08-30 11:32:02 | Re: pg_verify_checksums vs windows |
Previous Message | Etsuro Fujita | 2018-08-30 11:27:52 | Extra word in src/backend/optimizer/README |