| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-03-10 15:21:11 |
| Message-ID: | CAPpHfdv8KhoEohVG4_qB4OnWw74_gN-7UXmabDFmQUnsAx=y5g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 10, 2020 at 3:44 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Mar 10, 2020 at 01:05:40PM +0300, Alexander Korotkov wrote:
> > Two options seem reasonable to me in this case. The first is to pass
> > length as additional argument as you did. The second option is to
> > make argument a pointer to fixed-size array as following.
> >
> > extern bool BuildRestoreCommand(const char *restoreCommand,
> > const char *xlogpath, /* %p */
> > const char *xlogfname, /* %f */
> > const char *lastRestartPointFname, /* %r */
> > char (*commandResult)[MAXPGPATH]);
> >
> > Passing pointer to array of different size would cause an error. The
> > downside of this approach is that passing palloc'd chunk of memory as
> > commandResult would be less convenient.
>
> Thanks Alexander for the input. Another argument is that what you are
> suggesting here is not the usual project style, so I would still stick
> with two arguments to be consistent.
Yes, another argument is valid as well. I'm OK with current solution.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-03-10 15:30:06 | Re: Improve search for missing parent downlinks in amcheck |
| Previous Message | Alvaro Herrera | 2020-03-10 14:41:20 | Re: time for catalog/pg_cast.c? |