| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby |
| Date: | 2024-08-15 21:51:48 |
| Message-ID: | CAPpHfdv31iqGdMnW6Zbe=RMmcSRK02iE8iwYD=W=hRXNHRgd9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Aug 16, 2024 at 12:19 AM Alexander Korotkov
<akorotkov(at)postgresql(dot)org> wrote:
>
> Fix GetStrictOldestNonRemovableTransactionId() on standby
>
> e85662df44 implemented GetStrictOldestNonRemovableTransactionId() function
> for computation of xid horizon that avoid reporting of false errors.
> However, GetStrictOldestNonRemovableTransactionId() uses
> GetRunningTransactionData() even on standby leading to an assertion failure.
>
> Given that we decided to ignore KnownAssignedXids and standby can't have
> own running xids, we switch to use TransamVariables->nextXid as a xid horizon.
>
> Also, revise the comment regarding ignoring KnownAssignedXids with more
> detailed reasoning provided by Heikki.
I see the buildfarm failures. I will try to fix them shortly.
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-08-15 22:00:56 | pgsql: Add missing wait_for_catchup() to pg_visibility tap test |
| Previous Message | Alexander Korotkov | 2024-08-15 21:19:07 | pgsql: Fix GetStrictOldestNonRemovableTransactionId() on standby |