| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-02-26 19:03:06 |
| Message-ID: | CAPpHfdv0uQC0BuFKRWbakFfpUKxzqcm01V6oV5ufyknDwjxTZw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 25, 2020 at 1:48 PM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> I think usage of chmod() deserves comment. As I get default
> permissions are sufficient for work, but we need to set them to
> satisfy 'check PGDATA permissions' test.
I've added this comment myself. I've also fixes some indentation.
Patch now looks good to me. I'm going to push it if no objections.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0001-pg_rewind-Add-options-to-restore-WAL-files.patch | application/octet-stream | 25.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-02-26 19:34:26 | Re: Commit fest manager for 2020-03 |
| Previous Message | Vik Fearing | 2020-02-26 18:46:33 | Re: Error on failed COMMIT |