From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: gistchoose vs. bloat |
Date: | 2012-09-04 15:21:49 |
Message-ID: | CAPpHfduz2QvqxbpTNbOJk6MOY_p551m1yQVFBAiFac1y1Du4EA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Aug 20, 2012 at 9:13 PM, Alexander Korotkov <aekorotkov(at)gmail(dot)com>wrote:
> Current gistchoose code has a bug. I've started separate thread about it.
> http://archives.postgresql.org/pgsql-hackers/2012-08/msg00544.php
> Also, it obviously needs more comments.
>
> Current state of patch is more proof of concept than something ready. I'm
> going to change it in following ways:
> 1) We don't know how expensive user penalty function is. So, I'm going to
> change randomization algorithm so that it doesn't increase number of
> penalty calls in average.
> 2) Since, randomization could produce additional IO, there are probably no
> optimal solution for all the cases. We could introduce user-visible option
> which enables or disables randomization. However, default value of this
> option is another question.
>
>
>> Also, I think you should use random() rather than rand().
>>
>
> Thanks, will fix.
>
New version of patch is attached. Parameter "randomization" was introduced.
It controls whether to randomize choose. Choose algorithm was rewritten.
------
With best regards,
Alexander Korotkov.
Attachment | Content-Type | Size |
---|---|---|
gist_choose_bloat-0.2.patch | application/octet-stream | 9.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-09-04 15:21:53 | Re: pg_upgrade del/rmdir path fix |
Previous Message | Andrew Dunstan | 2012-09-04 15:17:12 | Re: 9.2 pg_upgrade regression tests on WIndows |