Re: Custom tuplesorts for extensions

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Custom tuplesorts for extensions
Date: 2022-07-21 14:40:19
Message-ID: CAPpHfdunCKv7Rg6wcj4A-kiXuBuAGn=oDbE6MnpFEhxh42EbTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, John!

On Thu, Jul 21, 2022 at 6:44 AM John Naylor
<john(dot)naylor(at)enterprisedb(dot)com> wrote:
> On Tue, Jul 12, 2022 at 3:23 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > There are some places, which potentially could cause a slowdown. I'm
> > going to make some experiments with that.
>
> I haven't looked at the patches, so I don't know of a specific place to look for a slowdown, but I thought it might help to perform the same query tests as my most recent test for evaluating qsort variants (some description in [1]), and here is the spreadsheet. Overall, the differences look like noise. A few cases with unabbreviatable text look a bit faster with the patch. I'm not sure if that's a real difference, but in any case I don't see a slowdown anywhere.
>
> [1] https://www.postgresql.org/message-id/CAFBsxsHeTACMP1JVQ%2Bm35-v2NkmEqsJMHLhEfWk4sTB5aw_jkQ%40mail.gmail.com

Great, thank you very much for the feedback!

------
Regards,
Alexander Korotkov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2022-07-21 14:41:54 Re: postgres_fdw: Fix bug in checking of return value of PQsendQuery().
Previous Message Fujii Masao 2022-07-21 14:22:26 postgres_fdw: Fix bug in checking of return value of PQsendQuery().