Re: [HACKERS] CUBE seems a bit confused about ORDER BY

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Stas Kelvich <stas(dot)kelvich(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [HACKERS] CUBE seems a bit confused about ORDER BY
Date: 2017-11-29 12:10:07
Message-ID: CAPpHfdubyJnZqgN35HjX8gvwZHgwiZuoX2DcEsWBnY3CsjrBCA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Wed, Nov 29, 2017 at 2:32 PM, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
wrote:

> 29 нояб. 2017 г., в 15:59, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
> написал(а):
>
>
> Sure, patch got some review. I've no objection against moving this to the
> next commitfest though.
> Since, these patches include bug fix, it's possible that someone will
> commit it before next commitfest.
>
> I've took a glance at the patch, here's what catches my eye in
> comments: corrdinate, dimenstions, descinding, stoty.
>

Thank you for catching these typos. Rebased patchset with fixes typos is
attached.

I'll try to provide meaningful review next week.
>

Cool, thanks.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
0001-cube-knn-fix-2.patch application/octet-stream 40.8 KB
0002-cube-knn-negative-coordinate-2.patch application/octet-stream 23.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2017-11-29 12:30:01 Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs
Previous Message Amit Khandekar 2017-11-29 11:55:34 Re: [HACKERS] UPDATE of partition key