| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Date: | 2024-05-07 11:45:48 |
| Message-ID: | CAPpHfduZ_C3VcXAg77ikhXGUCNV88V7Ty9T1krd6GVJ=xyhSJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 7, 2024 at 8:29 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Yeah, before the revert, that did:
> > - sjinf->syn_lefthand = replace_relid(sjinf->syn_lefthand, relid, subst);
> > That replace code seems to have always done a bms_copy()
>
> Hmm, not always; see e0477837c.
>
> What I'm trying to figure out here is whether we have a live bug
> in this area in released branches; and if so, why we've not seen
> reports of that.
I didn't yet spot a particular bug. But this place looks dangerous,
and it's very hard to prove there is no bug. Even if there is no bug,
it seems very easy to unintentionally add a bug here. Should we just
accept to always do bms_copy()?
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2024-05-07 12:00:11 | Re: CREATE DATABASE with filesystem cloning |
| Previous Message | Alexander Korotkov | 2024-05-07 11:42:16 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |