| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Indexes with INCLUDE columns and their support in B-tree |
| Date: | 2018-04-08 20:26:04 |
| Message-ID: | CAPpHfduWrysrT-qAhn+3Ea5+Mg6Vhc-oA6o2Z-hRCPRdvf3tiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Apr 8, 2018 at 7:58 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> Thank you, pushed
>
Thank you!
There is also patch for valgrind error in CheckIndexCompatible().
It appears that this function didn't initialize ii_NumIndexAttrs and
ii_NumIndexKeyAttrs before calling ComputeIndexAttrs(). This
variables weren't used before, but now they're used to determine
whether index column is key. Also, this patch makes ComputeIndexAttrs()
initialize classOidP elements with InvalidOid for non-key attributes.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| covering-fix-compute-index-attrs.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-04-08 20:36:03 | pgsql: Doc: clarify explanation of pg_dump usage. |
| Previous Message | Tom Lane | 2018-04-08 19:55:56 | pgsql: Cosmetic cleanups in initial catalog data. |