Re: POC, WIP: OR-clause support for indexes

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Andrei Lepikhov <lepihov(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, Peter Eisentraut <peter(at)eisentraut(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: 2024-11-25 07:08:41
Message-ID: CAPpHfduPWu6auMbR3SqmcJs0Ju459PHgy96MySUSxVScUJMxBA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Richard!

On Mon, Nov 25, 2024 at 8:28 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, Nov 21, 2024 at 3:34 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > I'm going to push this if no objections.
>
> Here is an Assert failure in match_orclause_to_indexcol.
>
> create table t (a int);
> create index on t (a);
>
> # explain select * from t where a <= 0 or a <= 1;
> server closed the connection unexpectedly
>
> The assertion is that the collected Const values cannot be NULL and
> cannot be zero. The latter part about zero values doesn't make sense
> to me. Why can't the values be zero?
>
> Assert(!value->constisnull && value->constvalue);

Yes, this is a dumb assertion. Removed.

------
Regards,
Alexander Korotkov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-11-25 07:12:56 Re: per backend I/O statistics
Previous Message Michael Paquier 2024-11-25 06:39:39 Re: Consider pipeline implicit transaction as a transaction block